Bringing CRF implementation inline with literature#2261
Merged
charliebudd merged 7 commits intoMay 27, 2021
Conversation
…ltiplication Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
rijobro
reviewed
May 27, 2021
rijobro
approved these changes
May 27, 2021
Co-authored-by: Richard Brown <33289025+rijobro@users.noreply.github.com> Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
7df2acc to
5c2a4d7
Compare
added 5 commits
May 27, 2021 11:15
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
…ning without cuda Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
25c52f2 to
52270d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version the compatability transform is extended to take into account neighbouring voxels. While this produces smoother results, it may well over smooth. While possibly worth some investigation it should be implemented as in the paper for now. This PR brings it inline with the literature.
Signed-off-by: chaliebudd charles.budd@kcl.ac.uk
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.