Skip to content

enhance downloading APIs#2242

Merged
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:enhance-downloading-apis
May 25, 2021
Merged

enhance downloading APIs#2242
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:enhance-downloading-apis

Conversation

@wyli

@wyli wyli commented May 24, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

  • enhance the download APIs with better default path values
  • remove duplicated check_hash in download_and_extract

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from Nic-Ma May 24, 2021 21:23
@wyli

wyli commented May 24, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test
/black

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for minor comments.

Thanks.

Comment thread monai/apps/utils.py
@wyli wyli enabled auto-merge (squash) May 25, 2021 07:43
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the enhance-downloading-apis branch from d877e73 to ff42ae3 Compare May 25, 2021 07:54
@wyli wyli merged commit c3a5bdd into Project-MONAI:dev May 25, 2021
wyli added a commit that referenced this pull request May 26, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 27, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 27, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 27, 2021
* enhance downloading APIs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli deleted the enhance-downloading-apis branch June 7, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants