Skip to content

1994 - adds pip install tests#2233

Merged
wyli merged 12 commits into
devfrom
adds-pypi-tests
May 24, 2021
Merged

1994 - adds pip install tests#2233
wyli merged 12 commits into
devfrom
adds-pypi-tests

Conversation

@wyli

@wyli wyli commented May 22, 2021

Copy link
Copy Markdown
Contributor

Fixes #1994

  • adds package min_tests for pre-merge ci/cd
  • adds package full unit tests for nightly ci/cd

Status

Ready

tested:

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.

wyli added 11 commits May 22, 2021 21:12
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Comment thread .github/workflows/cron.yml
@rijobro

rijobro commented May 24, 2021

Copy link
Copy Markdown
Contributor

Am I correct in understanding that this PR doesn't install from pypi, but from tar.gz? Do you think this changes the "realness" of the test at all?

@wyli

wyli commented May 24, 2021

Copy link
Copy Markdown
Contributor Author

Am I correct in understanding that this PR doesn't install from pypi, but from tar.gz? Do you think this changes the "realness" of the test at all?

yes this is quite realistic, except that "pip install requirements-dev.txt" might hide some dependency errors. but we need it to construct a testing environment. we should consider refactoring requirements*.txt.

for the tar.gz, another approach is to upload the tar.gz to testPyPI server and pip install from there. this pipeline will then depend on the availability of the test PyPI server, and for now I don't think it's really needed.

@rijobro

rijobro commented May 24, 2021

Copy link
Copy Markdown
Contributor

Ok, it sounds good to me. I can't really offer an opinion as to best practice, but happy to approve.

Has the workflow been run? Looking at the cron jobs and can't see cron-pip anywhere.

image

@wyli

wyli commented May 24, 2021

Copy link
Copy Markdown
Contributor Author

thanks, the cron will be available after merging the config. I had a test separately here: https://github.com/Project-MONAI/MONAI/actions/runs/867438967

@rijobro rijobro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@wyli wyli enabled auto-merge (squash) May 24, 2021 12:03
@wyli wyli merged commit 49f8ecd into dev May 24, 2021
@wyli wyli deleted the adds-pypi-tests branch May 24, 2021 12:33
wyli added a commit that referenced this pull request May 26, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 27, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 27, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 27, 2021
* add pypi quick tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cron pypi tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit b6d86d6.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise cron

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 44cddc0.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update setup.cfg

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up CI/CD for JIT extension packaging/release

2 participants