2172 caching grid for randaffine#2228
Merged
Merged
Conversation
rijobro
reviewed
May 21, 2021
rijobro
reviewed
May 21, 2021
rijobro
reviewed
May 21, 2021
Contributor
|
Perhaps I missed it, but in the unit test, do you ever check that the cached grid is being used? Or perhaps just check that the cached grid is not None. |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
Author
thanks -- added not None tests |
wyli
added a commit
that referenced
this pull request
May 26, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 27, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 27, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
May 27, 2021
* cache grid Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds cache tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #2172
Description
adds caching for the identity grid when the spatial size is not dynamic
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.