Skip to content

2095 fix multi-gpu issue in ClassificationSaver#2096

Merged
wyli merged 14 commits into
Project-MONAI:masterfrom
Nic-Ma:2095-fix-classificationsaver
Apr 27, 2021
Merged

2095 fix multi-gpu issue in ClassificationSaver#2096
wyli merged 14 commits into
Project-MONAI:masterfrom
Nic-Ma:2095-fix-classificationsaver

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor

Fixes #2095 .

Description

This PR fixed the hang issue in ClassificationSaver if ranks have different iterations.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 27, 2021 06:44
monai-bot and others added 2 commits April 27, 2021 06:46
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

/black

monai-bot and others added 2 commits April 27, 2021 07:16
Comment thread monai/handlers/classification_saver.py
Comment thread monai/handlers/classification_saver.py
Comment thread monai/handlers/classification_saver.py Outdated
Comment thread monai/handlers/classification_saver.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested a review from wyli April 27, 2021 11:41
monai-bot and others added 2 commits April 27, 2021 11:44
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

/black

Nic-Ma added 2 commits April 27, 2021 21:08
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

/black

@wyli wyli enabled auto-merge (squash) April 27, 2021 13:16
@wyli wyli merged commit 9e1a7d4 into Project-MONAI:master Apr 27, 2021
@Nic-Ma Nic-Ma deleted the 2095-fix-classificationsaver branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassificationSaver can't work if ranks have different iterations

3 participants