Skip to content

2018 Save inverted meta dict into state.batch#2065

Merged
wyli merged 7 commits into
Project-MONAI:masterfrom
Nic-Ma:2018-save-metadict
Apr 22, 2021
Merged

2018 Save inverted meta dict into state.batch#2065
wyli merged 7 commits into
Project-MONAI:masterfrom
Nic-Ma:2018-save-metadict

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

Fixes #2018 .

Description

As we can't support inverse for LoadImageD transform, this PR changed to save the inverted meta dict into engine.state.batch, then we can use this meta data to resample before saving.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Apr 21, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 21, 2021 18:20
monai-bot and others added 3 commits April 21, 2021 18:23
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) April 21, 2021 23:14

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 898d073 into Project-MONAI:master Apr 22, 2021
@Nic-Ma Nic-Ma deleted the 2018-save-metadict branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing inverse for LoadImageD transform

3 participants