Skip to content

1985 Add SaliencyInferer#2006

Merged
Nic-Ma merged 10 commits into
Project-MONAI:masterfrom
Nic-Ma:1985-add-saliencyinferer
Apr 14, 2021
Merged

1985 Add SaliencyInferer#2006
Nic-Ma merged 10 commits into
Project-MONAI:masterfrom
Nic-Ma:1985-add-saliencyinferer

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Apr 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1985 .

Description

This PR added the SaliencyInferer to leverage GradCam module.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 7 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #32 from Project-MONAI/master
cd16a13 
merge master
@Nic-Ma
Merge pull request #78 from Project-MONAI/master
ec4e432 
merge master
@Nic-Ma
[DLMED] add SaliencyInferer
2e19cf4 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] enhance CAM logic
ca23c58 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add unit tests
c1e7b6a 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix flake8
a360c99 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma marked this pull request as ready for review April 14, 2021 09:46
@Nic-Ma Nic-Ma changed the title [WIP] 1985 Add SaliencyInferer 1985 Add SaliencyInferer Apr 14, 2021
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli and removed request for wyli April 14, 2021 09:47
@Nic-Ma

Nic-Ma commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

/black

rijobro
rijobro approved these changes Apr 14, 2021
View reviewed changes

@rijobro rijobro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! A few comments, feel free to use them or not.

Comment thread monai/inferers/inferer.py Outdated
Comment thread monai/inferers/inferer.py
@Nic-Ma @rijobro
[DLMED] fix typo
b383104 
Co-authored-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 1985-add-saliencyinferer branch from f2c4bdb to b383104 Compare April 14, 2021 14:29
@Nic-Ma Nic-Ma enabled auto-merge (squash) April 14, 2021 14:33
@Nic-Ma Nic-Ma merged commit 2d8595d into Project-MONAI:master Apr 14, 2021
wyli
wyli reviewed Apr 14, 2021
View reviewed changes
Comment thread monai/inferers/inferer.py
@Nic-Ma Nic-Ma deleted the 1985-add-saliencyinferer branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments
@rijobro rijobro rijobro approved these changes
@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add SaliencyInferer

3 participants

@Nic-Ma @wyli @rijobro