Skip to content

1939 Add strict_shape option in CheckpointLoader#1946

Merged
wyli merged 4 commits into
Project-MONAI:masterfrom
Nic-Ma:1939-add-strict-shape
Apr 5, 2021
Merged

1939 Add strict_shape option in CheckpointLoader#1946
wyli merged 4 commits into
Project-MONAI:masterfrom
Nic-Ma:1939-add-strict-shape

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Apr 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1939 .

Description

This PR added the strict_shape option to the CheckpointLoader handler.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 1939 Add strict_shape option in CheckpointLoader 1939 Add strict_shape option in CheckpointLoader Apr 5, 2021
@Nic-Ma

Nic-Ma commented Apr 5, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 5, 2021 16:06
@Nic-Ma Nic-Ma marked this pull request as ready for review April 5, 2021 16:07
Nic-Ma and others added 4 commits April 5, 2021 19:10
@Nic-Ma @wyli
[DLMED] add strict_shape option
e5b2094 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma @wyli
[DLMED] add unit tests
dfc76d9 
Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli
update test case
ac086b7 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes test config
b406974 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 1939-add-strict-shape branch from e746a53 to b406974 Compare April 5, 2021 18:10
wyli
wyli approved these changes Apr 5, 2021
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a non-breaking change

@wyli wyli enabled auto-merge (squash) April 5, 2021 18:44
@wyli wyli merged commit f1db865 into Project-MONAI:master Apr 5, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@Nic-Ma @wyli @nsrivathsa
1939 Add strict_shape option in CheckpointLoader (Project-MONAI#1946)
5e7be9b 
* [DLMED] add strict_shape option

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add unit tests

Signed-off-by: Nic Ma <nma@nvidia.com>

* update test case

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes test config

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
@Nic-Ma Nic-Ma deleted the 1939-add-strict-shape branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes
@ericspod ericspod Awaiting requested review from ericspod
@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add strict_shape option to CheckpointLoader

2 participants

@Nic-Ma @wyli