Skip to content

1821 add slicing index and negative index for datasets#1885

Merged
Nic-Ma merged 16 commits into
Project-MONAI:masterfrom
Nic-Ma:1821-add-slicing-datasets
Mar 29, 2021
Merged

1821 add slicing index and negative index for datasets#1885
Nic-Ma merged 16 commits into
Project-MONAI:masterfrom
Nic-Ma:1821-add-slicing-datasets

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1821 .

Description

This PR enhanced datasets to support slicing index and negative index.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 5 commits February 1, 2021 19:15
@Nic-Ma

Nic-Ma commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma marked this pull request as ready for review March 29, 2021 05:50
@Nic-Ma Nic-Ma changed the title [WIP] 1821 add slicing datasets 1821 add slicing index for datasets Mar 29, 2021
@Nic-Ma Nic-Ma changed the title 1821 add slicing index for datasets 1821 add slicing index and negative index for datasets Mar 29, 2021
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 29, 2021 05:51
monai-bot and others added 3 commits March 29, 2021 05:53
@monai-bot
[MONAI] python code formatting
f4dcc54 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma
Merge branch 'master' into 1821-add-slicing-datasets
4bda872
@Nic-Ma
[DLMED] fix typo
7c2491d 
Signed-off-by: Nic Ma <nma@nvidia.com>
wyli
wyli reviewed Mar 29, 2021
View reviewed changes
Comment thread monai/data/dataset.py Outdated
@Nic-Ma

Nic-Ma commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli and @ericspod ,

I updated the PR according to both of your comments.
Could you please help review it again?

Thanks in advance.

ericspod
ericspod reviewed Mar 29, 2021
View reviewed changes
Comment thread monai/data/dataset.py Outdated
Nic-Ma added 3 commits March 29, 2021 20:52
@Nic-Ma
[DLMED] update doc-strings and typehints
7c1fa7e 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix flake8 issue
1b1203b 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix flake8 issue
317defb 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) March 29, 2021 15:45
wyli
wyli reviewed Mar 29, 2021
View reviewed changes
Comment thread monai/data/dataset.py Outdated
wyli added 3 commits March 29, 2021 17:45
@wyli
supporting sequence indexing
2273405 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adds test cases
ed76822 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge branch 'master' into 1821-add-slicing-datasets
ac67ddb
@Nic-Ma Nic-Ma merged commit f5426c8 into Project-MONAI:master Mar 29, 2021
@Nic-Ma Nic-Ma deleted the 1821-add-slicing-datasets branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments
@ericspod ericspod ericspod approved these changes
@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flexible indexing for CacheDataset

4 participants

@Nic-Ma @wyli @ericspod @monai-bot