Skip to content

1862 Fix checkpoint read permission#1863

Merged
wyli merged 9 commits into
Project-MONAI:masterfrom
Nic-Ma:1862-fix-checkpoint-permission
Mar 26, 2021
Merged

1862 Fix checkpoint read permission#1863
wyli merged 9 commits into
Project-MONAI:masterfrom
Nic-Ma:1862-fix-checkpoint-permission

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

Fixes #1862 .

Description

This PR fixed the read permission issue of checkpoint, based on suggestion from @vfdev-5 in pytorch/ignite#1876.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Mar 26, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from atbenmurray, ericspod, rijobro and wyli and removed request for atbenmurray March 26, 2021 11:58
Comment thread monai/handlers/checkpoint_saver.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
Comment thread monai/handlers/checkpoint_saver.py Outdated

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we'll revert this after the upstream fix release

@wyli wyli enabled auto-merge (squash) March 26, 2021 12:55
@wyli wyli merged commit 28e000d into Project-MONAI:master Mar 26, 2021
@Nic-Ma Nic-Ma deleted the 1862-fix-checkpoint-permission branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkpoint handler save files with wrong permissions

4 participants