Skip to content

1852 Fix the prefetch issue in SmartCacheDataset #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 4 commits into from
Mar 26, 2021
Merged

1852 Fix the prefetch issue in SmartCacheDataset #1855

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42a45e0
Merge pull request #19 from Project-MONAI/master
Nic-Ma Feb 1, 2021
cd16a13
Merge pull request #32 from Project-MONAI/master
Nic-Ma Feb 24, 2021
ecbee4e
Merge pull request #54 from Project-MONAI/master
Nic-Ma Mar 26, 2021
0127823
[DLMED] fix SmartCache warning
Nic-Ma Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions monai/data/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,9 @@ class SmartCacheDataset(Randomizable, CacheDataset):
This replacement will not work if setting the `multiprocessing_context` of DataLoader to `spawn`
or on windows(the default multiprocessing method is `spawn`) and setting `num_workers` greater than 0.

If using MONAI workflows, please add `SmartCacheHandler` to the handler list of trainer,
otherwise, please make sure to call `start()`, `update_cache()`, `shutdown()` during training.

Args:
data: input data to load and transform to generate dataset for model.
transform: transforms to execute operations on input data.
Expand Down Expand Up @@ -800,18 +803,6 @@ def __len__(self):
"""
return self.cache_num

def __getitem__(self, index):
"""
Raise exception if didn't call the expected APIs in SmartCacheDataset.

"""
if not self.is_started():
raise RuntimeError(
"if using MONAI workflows, please add `SmartCacheHandler` to the handler list of trainer,"
"otherwise, please make sure to call `start()`, `update_cache()`, `shutdown()` during training."
)
return super().__getitem__(index)


class ZipDataset(Dataset):
"""
Expand Down