Update SmartCachePatchWSIDataset and add unittests

[bhashemian]

Description

Turn shuffling off for SmartCachePatchWSIDataset, since PatchWSIDataset object does not support item assignment, and added unittests for SmartCachePatchWSIDataset.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?

Thanks.

[bhashemian]

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?

Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

[Nic-Ma]

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?
Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Hi @behxyz ,

You can refer to this test program: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_handler_smartcache.py

Thanks.

[bhashemian]

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?
Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Hi @behxyz ,

You can refer to this test program: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_handler_smartcache.py

Thanks.

@Nic-Ma, I need to finish all the other pathology components by the end of week and I've got a lot on my plate. I'll go back to it after that if you don't mind.

[Nic-Ma]

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?
Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Hi @behxyz ,
You can refer to this test program: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_handler_smartcache.py
Thanks.

@Nic-Ma, I need to finish all the other pathology components by the end of week and I've got a lot on my plate. I'll go back to it after that if you don't mind.

Sure, sounds good.
Thanks.

[wyli]

could you please address https://github.com/Project-MONAI/MONAI/pull/1853/files#r602317744 in this PR?

[bhashemian]

could you please address https://github.com/Project-MONAI/MONAI/pull/1853/files#r602317744 in this PR?

@wyli, I'll do it later in another PR since it affects almost all the pathology related unittests. It's on my to-do list.

will be addressed in a follow up