1837 fixes collating data types#1839
Merged
Merged
Conversation
Contributor
|
The error was complaining about float/double mismatch, but the fix seems to focus on cuda/cpu. Could you explain? This will presumably cause conflict with #1836. |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
195e824 to
2c686ae
Compare
wyli
commented
Mar 24, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
commented
Mar 24, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
Author
rijobro
approved these changes
Mar 24, 2021
Contributor
|
thanks @wyli ! |
Nic-Ma
approved these changes
Mar 24, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #1837
Description
Status
Ready
Types of changes