Skip to content

reduce randomly cropped amount to appease CI#1769

Merged
wyli merged 7 commits into
Project-MONAI:masterfrom
rijobro:fix_inverse_crop_CI
Mar 15, 2021
Merged

reduce randomly cropped amount to appease CI#1769
wyli merged 7 commits into
Project-MONAI:masterfrom
rijobro:fix_inverse_crop_CI

Conversation

@rijobro

@rijobro rijobro commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Hopefully fixes CI problem by reducing the number of voxels that are randomly cropped.

#1515

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@wyli

wyli commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

thanks, I'm looking into this as well, I'll push to this branch if I can locate the issue...

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the fix_inverse_crop_CI branch from d6bacdf to 3afbec5 Compare March 15, 2021 14:19
Comment thread tests/test_inverse.py
wyli and others added 4 commits March 15, 2021 14:27
…nverse_crop_CI

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
This reverts commit 809ae2c.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
If CI tests passed 2 or 3 times, we can merge it.

Thanks.

This reverts commit d6bacdf.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) March 15, 2021 15:44
@wyli wyli merged commit 1badb41 into Project-MONAI:master Mar 15, 2021
@rijobro rijobro deleted the fix_inverse_crop_CI branch March 15, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants