Skip to content

lossless inverse#1767

Merged
rijobro merged 10 commits into
Project-MONAI:masterfrom
rijobro:inverse_transform_lossless
Mar 16, 2021
Merged

lossless inverse#1767
rijobro merged 10 commits into
Project-MONAI:masterfrom
rijobro:inverse_transform_lossless

Conversation

@rijobro

@rijobro rijobro commented Mar 15, 2021 •
edited by wyli
Loading

Copy link
Copy Markdown
Contributor

Remaining lossless inverse transformations (croppad has already been merged: #1737).

This includes:

  • Flipd
  • RandFlipd
  • RandAxisFlipd
  • Orientationd (only lossless for orthogonal)
  • Rotate90d
  • RandRotate90d

part of #1515

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

rijobro added 4 commits March 15, 2021 12:30
@rijobro
lossless inverse
ea31dd7 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge remote-tracking branch 'MONAI/master' into inverse_transform_lo…
2a82685 
…ssless

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
code format
28f5a36 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
remove extra tests
fed515e 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from Nic-Ma and wyli March 15, 2021 15:54
wyli
wyli reviewed Mar 15, 2021
View reviewed changes
Comment thread monai/transforms/spatial/dictionary.py Outdated
wyli
wyli reviewed Mar 15, 2021
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I put some minor comments inline

Comment thread tests/test_inverse.py Outdated
Comment thread tests/test_inverse.py Outdated
Comment thread monai/transforms/spatial/dictionary.py
Comment thread monai/transforms/spatial/dictionary.py
rijobro added 3 commits March 16, 2021 08:56
@rijobro
update tests
c72407a 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge remote-tracking branch 'MONAI/master' into inverse_transform_lo…
b7b53cf 
…ssless

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge remote-tracking branch 'rijobro/inverse_transform_lossless' int…
0d26844 
…o inverse_transform_lossless

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
wyli
wyli approved these changes Mar 16, 2021
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks looks good to me. @Nic-Ma could you help confirm?

@rijobro

rijobro commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

@Nic-Ma If it's ok, I'm going to enable auto-merge so I can get on with next PR once this is merged. If you don't have the chance to review before it's merged, I'll open a new PR with your suggested modifications.

@rijobro rijobro enabled auto-merge (squash) March 16, 2021 10:32
@rijobro rijobro merged commit 3406398 into Project-MONAI:master Mar 16, 2021
@rijobro rijobro deleted the inverse_transform_lossless branch March 16, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes
@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rijobro @wyli