Skip to content

1756 update ignite version to 0.4.4#1759

Merged
Nic-Ma merged 9 commits into
Project-MONAI:masterfrom
Nic-Ma:1756-update-ignite-0.4.4
Mar 15, 2021
Merged

1756 update ignite version to 0.4.4#1759
Nic-Ma merged 9 commits into
Project-MONAI:masterfrom
Nic-Ma:1756-update-ignite-0.4.4

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Fixes #1756 .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test

@Nic-Ma Nic-Ma changed the title [WIP] 1756 update ignite version to 0.4.4 1756 update ignite version to 0.4.4 Mar 15, 2021
@Nic-Ma

Nic-Ma commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma marked this pull request as ready for review March 15, 2021 07:38
@Nic-Ma

Nic-Ma commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 15, 2021 07:39
@Nic-Ma

Nic-Ma commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Hi @vfdev-5 ,

Thanks for your great work on ignite project.
May I double confirm why you guys changed the default value of arg device from None to CPU in metrics?

Thanks.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

/black

@vfdev-5

vfdev-5 commented Mar 15, 2021

Copy link
Copy Markdown
Member

Hi @Nic-Ma , this is a BC-breaking change since 0.4.3 to explicitly manage metric's storage device and reduce the time of moving from CPU to GPU in DDP for reduction etc. Please, see pytorch/ignite#1082

@Nic-Ma

Nic-Ma commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Hi @vfdev-5 ,

Thanks for your explanation!
Could you please also help review this PR?

Thanks.

@vfdev-5 vfdev-5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR's impressions is good. I left few questions though (1 is more or less unrelated).

Comment thread monai/handlers/iteration_metric.py Outdated
Comment thread monai/handlers/roc_auc.py
@Nic-Ma Nic-Ma enabled auto-merge (squash) March 15, 2021 16:59

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma merged commit e5726d1 into Project-MONAI:master Mar 15, 2021
@Nic-Ma Nic-Ma deleted the 1756-update-ignite-0.4.4 branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update to use ignite 0.4.4

3 participants