Skip to content

1531 Fix evenly divisible issue in the AUC metric#1532

Merged
wyli merged 12 commits into
Project-MONAI:masterfrom
Nic-Ma:1531-fix-auc-issue
Feb 3, 2021
Merged

1531 Fix evenly divisible issue in the AUC metric#1532
wyli merged 12 commits into
Project-MONAI:masterfrom
Nic-Ma:1531-fix-auc-issue

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

Fixes #1531 .

Description

This PR fixed the issue in AUC metric if the data on different ranks have different length.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

/black

Comment thread tests/test_handler_rocauc_dist.py
@Nic-Ma

Nic-Ma commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma

Nic-Ma commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

/black

@wyli wyli merged commit f7565bf into Project-MONAI:master Feb 3, 2021
@Nic-Ma Nic-Ma deleted the 1531-fix-auc-issue branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AUC metric can't work in distributed validation if data length is different in ranks

3 participants