886 Add IterationMetric refer to to the EpochMetric in ignite#1488
Merged
Conversation
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
009a163 to
8f110a0
Compare
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
yiheng-wang-nv
approved these changes
Jan 22, 2021
yiheng-wang-nv
left a comment
Contributor
There was a problem hiding this comment.
Thanks Nic, I checked the code and I think the implementation is correct.
Contributor
Author
|
Hi @vfdev-5 , This PR added Thanks. |
Contributor
Author
|
Found a small issue in distributed training case, please don't merge it for now. Thanks. |
Member
|
Hi @Nic-Ma , let me see about that and we can talk about moving it to ignite... |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
Distributed training issue fixed, ready for review. |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
integratiion |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly fixes issue 886.
Description
This PR added
IterationMetrichandler to remove much duplicated code in all the metric handlers.And it can provide better extension as it saves the computation results of every iteration.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.