1412 global mutual information#1421
Merged
wyli merged 40 commits intoJan 12, 2021
Merged
Conversation
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Contributor
|
thanks, this is nice, could you add an integration test? like this file: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_seg_loss_integration.py (could be simpler than it, just wanted to verify that the new losses are differentiable)
|
…mutual-information Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Collaborator
Author
Sure, I am happy to work on that. |
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
…into 1412-global-mutual-information Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
2ea7b09 to
a539fa7
Compare
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
…into 1412-global-mutual-information
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
wyli
approved these changes
Jan 11, 2021
wyli
left a comment
Contributor
There was a problem hiding this comment.
thanks, there are a few typos i guess were introduced by auto substitutions, otherwise it looks good to me
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
wyli
reviewed
Jan 11, 2021
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
…into 1412-global-mutual-information
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
…mutual-information
…into 1412-global-mutual-information
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
00cb45f to
f616813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1412 .
Description
Add global mutual information
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.