Add test for printing debug info#1296
Merged
Merged
Conversation
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Contributor
|
I actually forgot to mention that please add |
Signed-off-by: Rich <33289025+rijobro@users.noreply.github.com>
Contributor
Author
|
@wyli I've also updated the bug report to use the debug output, so I'll also need to print OS, python version and CUDA/cuDNN version. As such, please don't merge this straight away. |
Contributor
|
sure there's a 'convert to draft' button on this PR page |
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Contributor
Author
|
@wyli thanks, done now. |
Signed-off-by: Rich <33289025+rijobro@users.noreply.github.com>
wyli
reviewed
Nov 26, 2020
Signed-off-by: Rich <33289025+rijobro@users.noreply.github.com>
remove utf-8 char Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/integration-test /black |
wyli
approved these changes
Dec 3, 2020
wyli
left a comment
Contributor
There was a problem hiding this comment.
thanks, passed all tests and also locally verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sorry, it seems I forgot to add the unit test for printing debug info.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.