Skip to content

feat: add liveness probe on scheduler extender#354

Merged
hami-robott[bot] merged 3 commits into
Project-HAMi:masterfrom
JasonHe-WQ:leaderElection
Jun 28, 2024
Merged

feat: add liveness probe on scheduler extender#354
hami-robott[bot] merged 3 commits into
Project-HAMi:masterfrom
JasonHe-WQ:leaderElection

Conversation

@JasonHe-WQ

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #353

Special notes for your reviewer:
Test needed

Does this PR introduce a user-facing change?:
Nothing

@hami-robott hami-robott Bot added the kind/feature new function label Jun 14, 2024
@hami-robott hami-robott Bot requested a review from archlitchi June 14, 2024 03:10
@hami-robott hami-robott Bot requested a review from wawa0210 June 14, 2024 03:10
@hami-robott hami-robott Bot added size/S and removed size/L labels Jun 14, 2024
@JasonHe-WQ JasonHe-WQ changed the title feat: add leaderElection feat: add liveness probe on scheduler extender Jun 14, 2024
Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>
Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>
@lengrongfu

Copy link
Copy Markdown
Member

@JasonHe-WQ Can you add livenessProbe to kube-scheduler container?

    livenessProbe:
      failureThreshold: 8
      httpGet:
        path: /healthz
        port: 10259
        scheme: HTTPS
      initialDelaySeconds: 10
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 15

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>
@JasonHe-WQ

Copy link
Copy Markdown
Contributor Author

@JasonHe-WQ Can you add livenessProbe to kube-scheduler container?

    livenessProbe:
      failureThreshold: 8
      httpGet:
        path: /healthz
        port: 10259
        scheme: HTTPS
      initialDelaySeconds: 10
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 15

Done

@lengrongfu

Copy link
Copy Markdown
Member

LGTM~

@wawa0210

Copy link
Copy Markdown
Member

/lgtm
/approve

@hami-robott

hami-robott Bot commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonHe-WQ, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott Bot added the approved label Jun 28, 2024
@hami-robott hami-robott Bot merged commit 8b5e5b8 into Project-HAMi:master Jun 28, 2024
@JasonHe-WQ JasonHe-WQ deleted the leaderElection branch July 1, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat]: add liveness probe

3 participants