Skip to content

setup multi-arch build#297

Closed
morlay wants to merge 1 commit into
Project-HAMi:masterfrom
morlay:multi-arch
Closed

setup multi-arch build#297
morlay wants to merge 1 commit into
Project-HAMi:masterfrom
morlay:multi-arch

Conversation

@morlay

@morlay morlay commented May 6, 2024

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

to build multi arch images with amd64/arm64

Which issue(s) this PR fixes:
no

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
no

@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown

Hi @morlay,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@github-actions github-actions Bot added the kind/feature new function label May 6, 2024
@morlay

morlay commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

Known Issue:

lib/mlu/* is x86-64 only. but now could make vgpu multi-arch supported first.

$ file lib/mlu/*
lib/mlu/cntopo:          ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=f4e84ebeefefc76c0dbf925d5b28b3c2318f9342, stripped
lib/mlu/libcndev.so:     ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=4e4a1717580ce285e50565322b7a87cf3d3d1422, stripped
lib/mlu/smlu-containerd: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=e3ea08302634487ef73ba64cc55e801d1a085920, with debug_info, not stripped

@morlay morlay force-pushed the multi-arch branch 4 times, most recently from 4489074 to 927a5ab Compare May 6, 2024 04:38
@morlay

morlay commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

/auto-cc

@hami-robott

hami-robott Bot commented May 31, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: morlay
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Morlay <morlay.null@gmail.com>
@CoderTH

CoderTH commented Jun 6, 2024

Copy link
Copy Markdown
Member

Is there anything wrong with this pr now?

@wawa0210

Copy link
Copy Markdown
Member

Currently, HAMi images already support multiple architectures.

@wawa0210 wawa0210 closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants