Skip to content

Update HOWTO_DEVELOPMENT_LOCAL_SETUP.md for more recent versions of D…#2338

Merged
mau11 merged 1 commit intomainfrom
ibrand-docker-docs-update
May 23, 2024
Merged

Update HOWTO_DEVELOPMENT_LOCAL_SETUP.md for more recent versions of D…#2338
mau11 merged 1 commit intomainfrom
ibrand-docker-docs-update

Conversation

@ibrand
Copy link
Copy Markdown
Collaborator

@ibrand ibrand commented Feb 28, 2024

…ocker that don't include docker-compose

Noticed today when I updated Docker that it no longer comes with docker-compose on Mac. Added instructions for how I installed it.

Checklist:

…ocker that don't include docker-compose

Noticed today when I updated Docker that it no longer comes with docker-compose on Mac. Added instructions for how I installed it.
@engelhartrueben
Copy link
Copy Markdown
Collaborator

lgtm! @mau11 can we get this in before the Node20 update goes out?

mau11
mau11 previously approved these changes May 23, 2024
Copy link
Copy Markdown
Collaborator

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ibrand!

@mau11 mau11 changed the base branch from main to new-node-20-branch May 23, 2024 00:17
@mau11 mau11 changed the base branch from new-node-20-branch to main May 23, 2024 17:09
@mau11 mau11 dismissed their stale review May 23, 2024 17:09

The base branch was changed.

Copy link
Copy Markdown
Collaborator

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! will merge this to main instead of the new node 20 branch (I previously switched the base branch)

@mau11 mau11 merged commit 308daf8 into main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants