Flyout navigation not working properly[MAUI.Prism] Android

[SarthakB26]

Doing _navigationService.NavigateAsync("NavigationPage/ViewB") From Flyout Page will result in opening ViewB as a push modal also no hamburger icon will be visible on ViewB page.

Steps To Reproduce

1. Open Prism.Maui app
2. Go to flyout page
3. Click on hambergur icon and select ViewB Button from Flyout
4. You will see instead of setting ViewB as detail page of Flyout page, ViewB will open as a PushModal page and no back or hamburger button will be visible on ViewB page

Testing on Latest Maui and Prism version
Maui Flyout works fine

Video attached of Sample Prism app

Android.Emulator.-.pixel_5_-_api_32_5554.2023-02-15.16-50-44.mp4

Please let me know if there is any workaround to fix this. Really important for migration

[SarthakB26]

While debugging what I found out is after doing _navigationService.NavigateAsync("NavigationPage/ViewB").
ProcessNavigation method called with single segment i.e ViewB even while one ProcessNavigation method already in run with two segments i.e NavigationPage and ViewB

This recursive calling might be the issue here but I am not sure why its calling again or this is might be how things work in prims

[berhir]

hi @SarthakB26, did you find a workaround for this issue?

[SarthakB26]

For now you can get FlyoutPage from Application.MainPage as FlyoutPage and then sets its detail page by yourself rather then through prism navigation service.
It's dirty I know but works for me

[berhir]

Thanks. I did a short investigation and found the issue. This commit causes the issue: https://github.com/PrismLibrary/Prism.Maui/pull/120/commits/9113b7d609570286f48a36c74e3009d25ade0e35
More precisely these lines:

if (!useModalNavigation.Value && !MvvmHelpers.HasNavigationPageParent(currentPage))
    useModalNavigation = true;

The FlyoutPage does not have a NavigationPage parent, that's why useModalNavigation is always true.
When I comment those lines, my app works as expected, but the tests are failing.

I guess instead of MvvmHelpers.HasNavigationPageParent(currentPage) we should use UseModalNavigation()and add a check for FlyoutPage.
I must do some more testing and then I can create a PR if you agree @dansiegel

[berhir]

The solution was even simpler. I created a PR with the fix. And I added a new test that fails without my changes and succeeds with my changes.