Conversation
anmenaga
reviewed
Apr 12, 2024
anmenaga
left a comment
There was a problem hiding this comment.
Please add 2 examples of output to PR description for:
- running a resource operation in what-if mode;
- running a configuration operation in what-if mode.
Member
|
@tgauth can you address the merge conflicts? |
Collaborator
Author
done! |
SteveL-MSFT
requested changes
May 15, 2024
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Some minor feedback, otherwise looks pretty good
SteveL-MSFT
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
what-ifflag toconfig setwith synthetic test as a starting point, until resources can eventually implementwhat-ifdeletewithwhat-ifis not a supported scenarioPR Context
WhatIf#70config set -wwhen actual state already matches desired state (first test in dsc_whatif.tests.ps1):config set -wwhen actual state does not match desired state (second test in dsc_whatif.tests.ps1):