Revert changes required for ARMv2 experiment#1353
Revert changes required for ARMv2 experiment#1353SteveL-MSFT merged 1 commit intoPowerShell:mainfrom
Conversation
1aa2317 to
0dfdb10
Compare
Since we no longer expect DSC to ingest ARMv2 as generated by Bicep (in favor of Bicep invoking DSC resources via the gRPC extension), we can remove this unfinished work that simply got our demos running again. This deserialization approach was a cheap workaround, we had not yet revisited the design to properly support symbolic names (such as fixing resource IDs, dependency resolution, etc.). We also don't need to add the Bicep emitted fields that we were just skipping.
0dfdb10 to
7b0556c
Compare
|
@andyleejordan - isn't the |
🤷 as far as I could tell it was a lot of hassle for little if any gain as it was really to support |
Thanks for the explanation, Andy, and I get that part indeed. Symbolic names are more towards v2 (or even are). There might be other ways to loop for sure, but I can't think of any atm. |
michaeltlombardi
left a comment
There was a problem hiding this comment.
Code changes look good to me - I think there's still some open questions on impact to other functionality (copy loops), but I prefer that functionality be pushed to higher order tools (bicep, a DSC config builder in PowerShell, whatever) instead of being inherent to the engine / configuration document.
|
@SteveL-MSFT this is ready to merge! |
PR Summary
Since we no longer expect DSC to ingest ARMv2 as generated by Bicep (in favor of Bicep invoking DSC resources via the gRPC extension), we can remove this unfinished work that simply got our demos running again.
PR Context
This deserialization approach was a cheap workaround, we had not yet revisited the design to properly support symbolic names (such as fixing resource IDs, dependency resolution, etc.).
We also don't need to add the Bicep emitted fields that we were just skipping.