fix #207 in cholesky decomposition #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A precedence error in the binary block of #inject:into was causing cholesky decomposition to fail for matrices of size more than 3. It has been corrected by adding parenthesis in the block. New tests with matrix size more than 3 has also been added.
Contributor
Author
|
@olekscode Can you please review this when you are free? |
olekscode
approved these changes
Oct 17, 2021
Member
olekscode
left a comment
There was a problem hiding this comment.
Looks good!
If the tests pass, we can merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #207
A precedence error in the binary block of
#inject:intowas causing Cholesky decomposition to fail for matrices of size more than 3.Code before
where
sum + (upperTriangular at: k at: i)was being calculated firstWhy did tests pass before
In the tests, the matrix size was 3.
So, the value of
sumwas always zero, hence the precedence did not matter.Change introduced