Skip to content

add atRow: method for PMMatrix #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergeStinckwich merged 4 commits into from
May 18, 2021
Merged

add atRow: method for PMMatrix #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5fd0c0
add atRow: method for PMMatrix
rakki-18 May 9, 2021
300f536
add tests for atRow: method
rakki-18 May 15, 2021
39e618b
change argument name
rakki-18 May 15, 2021
24c0012
correct typo
rakki-18 May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Math-Matrix/PMMatrix.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,9 @@ PMMatrix >> atAllPut: element [
]

{ #category : #'cell accessing' }
PMMatrix >> atColumn: anInteger [
PMMatrix >> atColumn: aColumnNumber [

^ self columnAt: anInteger
^ self columnAt: aColumnNumber
]

{ #category : #'cell accessing' }
Expand Down Expand Up @@ -311,6 +311,12 @@ PMMatrix >> atColumn: aColumnNumber put: aCollection startingAt: rowNumber [

]

{ #category : #'cell accessing' }
Copy link
Contributor

@hemalvarambhia hemalvarambhia May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any programmer tests to write here, @rakki-18 ? I seems simple enough

Copy link
Contributor Author

@rakki-18 rakki-18 May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemalvarambhia Yeah sure, I will write some tests.

Copy link
Contributor

@hemalvarambhia hemalvarambhia May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemalvarambhia Yeah sure, I will write some tests.

TYSM

PMMatrix >> atRow: aRowNumber [
"answers the aRowNumber-th row in the receiver"
^ self rowAt: aRowNumber
]

{ #category : #'cell accessing' }
PMMatrix >> atRow: rowIndex put: aCollection [

Expand Down
10 changes: 10 additions & 0 deletions src/Math-Tests-Matrix/PMMatrixTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@ PMMatrixTest >> testAtColumnPutRepeat [
self assert: a equals: (PMMatrix rows: #(#(1 nil nil) #(1 nil nil) #(nil nil nil))).
]

{ #category : #tests }
PMMatrixTest >> testAtRow [

| a |
a := PMMatrix rows: #(#(1 2 3) #(2 3 4)).

self assert: (a atRow: 2) equals: (#(2 3 4) asPMVector).
self assert: (a atRow: 1) equals: (#(1 2 3) asPMVector).
]

{ #category : #'linear algebra' }
PMMatrixTest >> testAtRowPutAtColumnPut [
| a |
Expand Down