testHouseholder added #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| u := #(-1 0 1) asPMVector. "`x <= 0` when x = -1" | ||
| w := u householder. | ||
| self | ||
| assert: w class equals: Array; |
Contributor
There was a problem hiding this comment.
I think you can omit this check.
| u := #(1.00001 2.00007) asPMVector. "`x <= 0` when x = 1.00001" | ||
| w := u householder. | ||
| self | ||
| assert: w class equals: Array; |
Contributor
There was a problem hiding this comment.
You can omit this, too, I think.
Member
|
Thank you @mabdi for your contribution ! Can you take care about the remarks of Hemal and we can integrate your test. |
Contributor
Author
|
Of course, I omitted the type-assertions. Please check again. |
Member
|
Thank you for increasing our test coverage ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submit this pull request to suggest a test method
PMVectorTest >> testHouseholder.We noticed that the method #householder is never executed by any of the tests in PMVectorTest. Therefore we created a test method which uses two vectors to exercise both branches in line 203
(x <=0) ifTrue: [x -u] ifFalse: [0 - s / (x + u)]. In the former vectorx = -1forces the ifTrue branch in the latter vectorx = 1.00001forces the ifFalse branch.Note that these suggestions are adapted from a test amplification tool called SmallAmp (https://github.com/mabdi/small-amp). SmallAmp executes existing tests, sees which parts of the class under test are not covered and then suggests improvements on the test methods.
I hope you will accept this pull request. It would illustrate that SmallAmp makes relevant suggestions.
Mehrdad Abdi.