Implement test data generator - #405
Merged
Merged
Conversation
This bypasses the pool managers, and speeds tests up by >50%
Data validation is done in the denoise tests and don't need to be repeated here
Contributor
Author
|
Test failures seem to be due to the dependency updates. Will fix these tests to make them more robust to such numerical artifacts |
This probably broke because of the matplotlib update
Aratz
marked this pull request as ready for review
July 8, 2026 13:22
ptajvar
approved these changes
Jul 9, 2026
ptajvar
left a comment
Contributor
There was a problem hiding this comment.
Great addition! I am just wondering whether it should live under common or pna given that other than topology.py, the rest is mostly exclusive for pna. Looks good to go to me otherwise.
Contributor
Author
|
Ah, I see, I think maybe for now it can stay where it is, if we develop a new product or something we can see if it's worth to move it elsewhere 👍 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a test data generator. The generator is split into three parts:
This PR then reworks the denoise tests (currently the slowest of the testbase) to use synthetic data. Overall this cuts the total run time by around 3 minutes.
Fixes: PNA-2602
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Each function and helper function of the test generator has its own tests. This has also been tested end to end by generating fastq files and putting them through the nf-core pipeline.
PR checklist: