use cross-platform paths for migration#26
Merged
PiMaker merged 1 commit intoPiMaker:mainfrom Dec 26, 2023
Merged
Conversation
Owner
|
Had to double-check that Thank you for the contribution! I'll make sure to give it a quick test on Windows too and ship it with the next release (though I don't know when I'll have time for that yet). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
On platforms other than Windows, the migration process creates
LTCGI.cgincand gizmo files outside of the Assets folder.Dependent shaders will error out due to the include path not pointing to a valid file.
Proposed solution
Path.Combineinstead of hardcoded path separatorsDirectory.CreateDirectoryto create the folder structure recursively. (Using AssetDatabase is not necessary, as we're not injecting any metadata.)Tested
On Linux, but the behavior is expected to be the same on all platforms.