Fix Dying Breath Curse effect mod not working#9173
Merged
LocalIdentity merged 1 commit intodevfrom Nov 5, 2025
Merged
Conversation
enemyDB was not populated with `EnemyModifier` mods until doActorMisc was run on line 3078 so all the calls to enemyDB before that could be potentially missing mods We now pull the call out of doMisc and run it early in the pass so all the subsequent calls to enemyDB will include them
3 tasks
LocalIdentity
pushed a commit
that referenced
this pull request
Nov 5, 2025
With my change in #9173, I moved the place in the file where EnemyModifiers were calculated but didn't realise that they also need to be recalculated later so that mods that rely on "AffectedBy" x still work Changed it to use a cache so it doesn't duplicate earlier added mods
LocalIdentity
added a commit
that referenced
this pull request
Nov 15, 2025
* Fix Heraldry not granting Exposure to enemies With my change in #9173, I moved the place in the file where EnemyModifiers were calculated but didn't realise that they also need to be recalculated later so that mods that rely on "AffectedBy" x still work Changed it to use a cache so it doesn't duplicate earlier added mods * Test for bug * Fix test * Enemy curse effect test --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Dec 15, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Dec 15, 2025
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9173 * Fix merge conflict * Fix from #9179 Fix from PathOfBuildingCommunity/PathOfBuilding#9179 * Fix from #9264) Fix from PathOfBuildingCommunity/PathOfBuilding#9264 * Fix typo * Try different weapon * Remove tests --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9171
Description of the problem being solved:
enemyDB was not populated with
EnemyModifiermods until doActorMisc was run on line 3078 so all the calls to enemyDB before that could be potentially missing modsWe now pull the call out of doMisc and run it early in the pass so all the subsequent calls to enemyDB will include them
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/d377m0au
Before screenshot:
After screenshot: