Add support for "Farewell to Flesh" (Lycia Bloodline Herald Ascendancy Node)#9108
Merged
Wires77 merged 5 commits intoPathOfBuildingCommunity:devfrom Nov 3, 2025
Merged
Conversation
- Previously only worked for Auras, now all skills that have reservation - Adds support for minion summoned by reservation skills (e.g. HoAg) - Adds support for "LifeReservedPercent" (previously only mana)
- Was causing crashes under some circumstances before
- Herald Skills have 2% more Buff Effect for every 1% of Maximum Mana they Reserve - Herald Skills and Minions from Herald Skills deal 1% more Damage for every 1% of Maximum Life those Skills Reserve
`ModStore` checked buff name via buffList[1].name, which didn't work for multi buff skills like "Herald of Agony"
Contributor
Author
Wires77
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of the problem being solved:
Adds parsing for Lycia Bloodline - "Farewell to Flesh" node
Enables parsing of skill-specific Mana/Life Reserved Percent Stats for non-Aura skills.
Adds new breakdown in
CalcSectionfor Herald Buff EffectSteps taken to verify a working solution:
Limitations:
Link to a build that showcases this PR:
Lycia Herald Test Build
After screenshot:
Node parsing:

Damage Mod applying:



HoT (has higher level arrogance):
HoP:
HoAg:
Buff Effect Applying

HoI: