Add support for Ritualist Bloodline#9055
Merged
Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom Oct 30, 2025
Merged
Add support for Ritualist Bloodline#9055Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom
Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom
Conversation
Wires77
requested changes
Oct 28, 2025
src/Classes/ItemsTab.lua
Outdated
Comment on lines
141
to
144
| slot.selIndex = 1 | ||
| slot:SetSelItemId(0) | ||
| self.build.buildFlag = true | ||
| return false |
Member
There was a problem hiding this comment.
Huh, good catch on this, we'll want to port this to PoB2 as well. I do think we want a check in here that isn't going to set the buildFlag every time, because when we do that we unnecessarily peg the CPU rebuilding on every frame. Maybe check if there is anything in there first?
Wires77
approved these changes
Oct 30, 2025
Member
Wires77
left a comment
There was a problem hiding this comment.
I went ahead and just removed the sections that set buildFlag. There may be a way to do that, but let's talk about it in a separate PR to get this one out the door for people.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Add support for Ritualist Bloodline Ascendancy, mostly Ring 3 and disabling utility flasks
Disabling item slots still not working but the parsing for Belts and Amulets is there, needs a separate PR to fix as a whole.
Link to a build that showcases this PR:
Bringer of Rain, Dance with Death
After screenshot: