Correct skill slot comparison for General's Cry detection#8954
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Aug 20, 2025
emmanuel-ferdman:dev
Merged
Correct skill slot comparison for General's Cry detection#8954LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom emmanuel-ferdman:dev
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
emmanuel-ferdman:dev
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
LocalIdentity
approved these changes
Aug 13, 2025
Contributor
|
@emmanuel-ferdman PR looks good but do you have an example build to show the difference that this PR makes |
LocalIdentity
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The
CalcMirages.lualogic for detecting the active "General's Cry" skill incorrectly comparedenv.player.mainSkill.socketGroup.slotto itself, causing the slot-matching condition to always be true. This could result in the wrong skill being used for cooldown and active property calculations. This small PR fixes it.Steps taken to verify a working solution:
skill.socketGroup.slot) against the main skill's socket group slot.--lua=luajitto confirm no issues.