Add text after red mods to show that PoB does not currently handle them#8925
Merged
LocalIdentity merged 5 commits intodevfrom Aug 7, 2025
Merged
Add text after red mods to show that PoB does not currently handle them#8925LocalIdentity merged 5 commits intodevfrom
LocalIdentity merged 5 commits intodevfrom
Conversation
added 3 commits
August 5, 2025 17:01
PoB does not calculate mods that have red text on them but many users do not know this. Adding this reminder text after all the lines should make it more obvious
The TooltipClass:CheckForUpdate had to be updated so that the tooltip updates correctly after changing the option. I kinda obsessed over optimizing this. Removed the secondary loop as the first one without the break statement will update all the records. Though this has the cost of doing more comparisons which could end up being more expensive if strings end up being compared often. Looking through current calls to this function it seems like it's all just addresses and booleans.
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 23, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 23, 2025
…em (#1173) Duplicate of PathOfBuildingCommunity/PathOfBuilding#8925 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
…em (PathOfBuildingCommunity#1173) Duplicate of PathOfBuildingCommunity/PathOfBuilding#8925 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoB does not calculate mods that have red text on them but many users do not know this. Adding this reminder text after all the lines should make it more obvious