Adding Beastcrafts to Item Crafter#8904
Merged
LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom Aug 1, 2025
Merged
Adding Beastcrafts to Item Crafter#8904LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom
Conversation
Nightblade
reviewed
Jul 28, 2025
src/Export/Scripts/mods.lua
Outdated
| end) | ||
|
|
||
| writeMods("../Data/BeastCraft.lua", function(mod) | ||
| return (mod.Id:match("Aspect") and mod.GenerationType == 2) -- Aspect Crafts |
Contributor
There was a problem hiding this comment.
Hi, I'm the officially unofficial imaginary mascot & chief pedant of PoB, and this line should be TAB indented. 😁
Contributor
Author
There was a problem hiding this comment.
Do you happen to know what the formatter settings are, EmmyLua was making changes across entire files, I would have thought that .editorconfig would work fine but its seems I'm missing a config.
I will go do that manually though
LocalIdentity
approved these changes
Aug 1, 2025
Contributor
LocalIdentity
left a comment
There was a problem hiding this comment.
I fixed a few issues with the PR and also removed flasks from being included as they are the exact same as t3 regular immunity mods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding the option to add Beastcraft Modifiers to items via
Add Modifierin the Item CrafterImplemented Beastcrafts for the Following BaseTypee:
utility_flasklife_flasksSteps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: