Fix Howlcrack causing inf DPS with Generals Cry#8881
Closed
LocalIdentity wants to merge 3 commits intodevfrom
Closed
Fix Howlcrack causing inf DPS with Generals Cry#8881LocalIdentity wants to merge 3 commits intodevfrom
LocalIdentity wants to merge 3 commits intodevfrom
Conversation
Howlcrack set the cooldown to 0 which caused inf DPS as we were assuming that all Mirages are spawned instantly and attack They spawn after a short delay so now the cooldown is modified to be at least the amount of time to spawn all the mirages and have them channel for 1s Not sure how to get the attack time for the main skill in the CalcMirages file so I can have it properly handle non-channeled skills too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howlcrack set the cooldown to 0 which caused inf DPS as we were assuming that all Mirages are spawned instantly and attack
They spawn after a short delay so now the cooldown is modified to be at least the amount of time to spawn all the mirages and have them channel for 1s
Not sure how to get the attack time for the main skill in the CalcMirages file so I can have it properly handle non-channeled skills too
Fixes #8842