Fix tincture quality effect multiplier rounding issue#8874
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Jul 21, 2025
Merged
Fix tincture quality effect multiplier rounding issue#8874LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
LocalIdentity
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tincture quality rounding issue:
https://www.reddit.com/r/pathofexile/comments/1foqn64/increased_tincture_effect_doesnt_round_the_way/
Also, this is what I got in-game vs pob (rip -3 divs of alt)
Description of the problem being solved:
As the post on Reddit says, "The game calculates the increased effect and rounds it first". Thus, a 35% increase effect and a +21% quality should result in 1.35 * 1.25 = 1.6875 ≈ 1.68. Therefore, a 19% ele pen should result in 19% * 1.68 = 31.92% ≈ 31%, instead of 19% * 1.6875 = 32.0625% ≈ 32%
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/XWWVPpewJTrs
Before screenshot:
After screenshot: