Fix Runegraft of the Bound scaling Facebreaker's incorrectly#8820
Merged
LocalIdentity merged 4 commits intodevfrom Jul 14, 2025
Merged
Fix Runegraft of the Bound scaling Facebreaker's incorrectly#8820LocalIdentity merged 4 commits intodevfrom
LocalIdentity merged 4 commits intodevfrom
Conversation
The mod was scaling the more multiplier on the gloves incorrectly by adding another More multiplier mod instead of modifying the existing mod This change also made me realise that we sometime incorrectly handle mods when the are 2 instances of them on an item e.g. T1 Life + crafted hybrid life shows up as 2 mods on the item so we process them in 2 loops which results in the rounding being incorrect Would have to somehow merge all similar mods on an item first then loop though them to fix it I think
Wires77
reviewed
Jul 10, 2025
| self.conditions = { } | ||
| end) | ||
|
|
||
| function ModStoreClass:ScaleAddMod(mod, scale) |
Member
There was a problem hiding this comment.
I feel like this should just be ScaleMod or ScaleReplaceMod instead to be more clear.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mod was scaling the more multiplier on the gloves incorrectly by adding another More multiplier mod instead of modifying the existing mod
This change also made me realise that we sometime incorrectly handle mods when the are 2 instances of them on an item
e.g. T1 Life + crafted hybrid life shows up as 2 mods on the item so we process them in 2 loops which results in the rounding being incorrect
Would have to somehow merge all similar mods on an item first then loop though them to fix it I think
Before:
After:
