Change Sacrificial Zeal to be opt in rather than opt out#8542
Change Sacrificial Zeal to be opt in rather than opt out#8542LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Initially when trying to fix issue PathOfBuildingCommunity#8421 i made the config default enabled to maintain current behaviour of it being on the moment Hand of the Fervent was equipped. I was under the impression that the ifFlag would prevent the config application function from running but that doesn't not seem to be the case. I've tried a few different ways of fixing this but i've decided that the best course of action would be to simply make the effect opt in rather than opt out.
|
PathOfBuilding/src/Modules/CalcOffence.lua Line 1718 in 78aa5c1 Hope that link works, haven't used github much to know until I post this comment
This works, check for both the condition set from the config, and the initial flag from the gloves. Then you can keep it enabled as default. |
|
I tried that and yeah it works but i'm not sure if i like it. On one hand i kinda want to keep the behavior the same but on the other i'm not sure if it's worth the complexity. |
|
Small issue with keeping it default off, is if the player equips the gloves, toggles Zeal on, then removes the gloves, Zeal is still applied. Good news is it's highlighted red in config. And maybe not a likely scenario anyway, as I assume most builds using these gloves wouldn't replace them, dunno though, never used them. So ya, just the small downside of being off by default, and staying on if removed. Not sure what's best there. EDIT: You probably knew this, just sharing insight lol |
Closes #8541
Description of the problem being solved:
Initially when trying to fix issue #8421 i made the config default enabled to maintain current behaviour of it being on the moment Hand of the Fervent was equipped. I was under the impression that the ifFlag would prevent the config application function from running but that doesn't not seem to be the case. I've tried a few different ways of fixing this but i've decided that the best course of action would be to simply make the effect opt in rather than opt out.