Fix Reset 'Enemy Damage Type' after 'Boss Skill Preset'#8284
Closed
n1tr0xs wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Closed
Fix Reset 'Enemy Damage Type' after 'Boss Skill Preset'#8284n1tr0xs wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
n1tr0xs wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Contributor
|
This change creates a functionality loss where the user is not able to select anything other than Average for Enemy Damage Type when Boss Skill Preset is set to None. I have not used this functionality much so do not know how important it is, but worth noting. |
Member
|
Yeah this wasnt done before like this due to the apply function being called every time and so we generally only want to set placeholders etc there, and ideally we would also want to remember the last value saved, this can be done by overwriting the control itself but that was too messy, I wish you luck in solving the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7870 .
Description of the problem being solved:
When you set the 'Boss Skill Preset' back to 'None' to see the normal EHP/Max Hit values the 'Enemy Damage Type' stays the same as whatever the Boss Skill was.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: