Fix maximum sustainable stages calculations ignoring certain buffs/mods#7678
Merged
LocalIdentity merged 8 commits intoPathOfBuildingCommunity:devfrom Jul 21, 2024
Merged
Conversation
Essentially an improved version of PathOfBuildingCommunity#5164 that utilizes skill cache functionality.
Nightblade
reviewed
Jul 13, 2024
0ffd499 to
b018769
Compare
LocalIdentity
approved these changes
Jul 21, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Essentially an improved version of #5164 that utilizes skill cache functionality. Additionally solves an order of calculations issue with certain effects (such as adrenaline) that get processed in
doActorMisccausing them to not be applied to maximum sustainable stages calculations.Steps taken to verify a working solution:
For output from #7162 see Paliak#6