Fix Projectile Attack Mod Parsing#3851
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Jan 3, 2022
Merged
Fix Projectile Attack Mod Parsing#3851LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Some skills are tagged ProjectileAttack (and Attack) but not Projectile. This generally means the skill deals projectile attack damage, but does not actually fire a projectile that can collide with terrain (e.g. Rain of Arrows, Storm Rain, Blast Rain, Toxic Rain, Artillery Ballista). In order for nodes like Lethality to correctly match these skills (while still matching all normal projectile attacks) we need to check the ProjectileAttack tag explicitly.
Contributor
Author
|
Assuming #3852 is merged before this, |
LocalIdentity
approved these changes
Jan 3, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Some skills are tagged ProjectileAttack (and Attack) but not Projectile. This generally means the skill deals projectile attack damage, but does not actually fire a projectile that can collide with terrain (e.g. Rain of Arrows, Storm Rain, Blast Rain, Toxic Rain, Artillery Ballista). In order for nodes like Lethality to correctly match these skills (while still matching all normal projectile attacks) we need to check the ProjectileAttack tag explicitly.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pastebin.com/ZeCpW2CU
Before screenshot:
After screenshot: