Fix ES bypass regression from #552#694
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Feb 4, 2025
Merged
Fix ES bypass regression from #552#694LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
LocalIdentity
approved these changes
Feb 4, 2025
d469ca7
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
#552 introduced a bug (who could've done such a thing?) where ES bypass + MoM did not work because code was relying on "EnergyShieldProtectsMana" flag which is not set to true by default in pob2 (should it?)
Added some tests which should prevent this happening again in the future
Before screenshot (current dev):
After screenshot: