Add scripts to propagate unique mods to their corresponding text#54
Merged
LocalIdentity merged 6 commits intoPathOfBuildingCommunity:devfrom Dec 27, 2024
PJacek:sync-uniques
Merged
Add scripts to propagate unique mods to their corresponding text#54LocalIdentity merged 6 commits intoPathOfBuildingCommunity:devfrom PJacek:sync-uniques
LocalIdentity merged 6 commits intoPathOfBuildingCommunity:devfrom
PJacek:sync-uniques
Conversation
Co-authored-by: Wires77 <1209372+Wires77@users.noreply.github.com>
LocalIdentity
approved these changes
Dec 27, 2024
Wires77
pushed a commit
that referenced
this pull request
Jan 19, 2025
Changes the base recoup time to 8 and adds support for some of the new elemental damage recoup mods Doesn't include support for minion recoup, phys damage prevented recoup or recoup speed Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve unique item handling by transitioning to internal mod names which are automatically populated with game data.
Unique item text is placed in the appropriate file in
src\Export\Uniques, with mods replaced by names fromsrc\Data\ModUnique.lua. TheuModsToText.luascript generates the final files, replacing the mods with their corresponding text from the data.Some unique mods are not entirely unique, sharing wording between implicit and explicit types or appearing multiple times. When GGG introduces changes and a mod changes unexpectedly or doesn’t update correctly, it can be fixed by finding the proper one in the list.
ModUnique.luashould not be committed without first updating the uniques, as this would remove the diff and make tracking changes difficult.Changes:
Jewels need further investigation as radii colors don't seem to work and I haven't checked if all new radii work correctly.