Fix objective_name_top & objective_score_top not sorted correctly (issue #75)#76
Merged
Patbox merged 1 commit intoPatbox:1.21.5from Apr 28, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objective_name_top & objective_score_top placeholders are now sorted correctly
My guess is that
ServerScoreboard#getScoreboardEntriesuses a Map which is not ordered by the score value.So in here:
TextPlaceholderAPI/src/main/java/eu/pb4/placeholders/impl/placeholder/builtin/ServerPlaceholders.java
Line 208 in 8a6dce7
We have to sort it manually after getting the score values. So I used a List instead of a Collection to use the
List#sort()method.It's working, I have tested in-game :)