Remove unneeded WINDOWS_COMPAT ConsoleAppender #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was originally added in Bukkit/CraftBukkit@6aafe7c5a10 as a workaround for BUKKIT-4956 to fix console output on Windows. I believe the original issue was related to LOG4J2-965 and fixed in apache/logging-log4j2@d04659c. Minecraft 1.12 finally updated the Log4J version so this issue is no longer present. Console output is still working fine on Windows after removing this.
kashike
approved these changes
Jun 13, 2017
zachbr
approved these changes
Jun 14, 2017
electronicboy
added a commit
to electronicboy/Paper
that referenced
this pull request
Aug 28, 2020
Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing CraftBukkit Changes: 3f57283 PaperMC#740: Fix EntityDamageEvent not being called for non EntityDamageSource for End Crystals 3c7143e SPIGOT-5953, SPIGOT-5914: Use LinkedHashMap to keep captured block states in order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally added in Bukkit/CraftBukkit@6aafe7c as a workaround for BUKKIT-4956 to fix console output on Windows.
I believe the original issue was related to LOG4J2-965 and fixed in apache/logging-log4j2@d04659c. Minecraft 1.12 finally updated the Log4J version so this issue is no longer present.
Console output is still working fine on Windows after removing this.
Note: I've added this to the original console improvements patch added in #728 because I'm not entirely sure if this would be still needed if we weren't using TerminalConsoleAppender. I believe it's unrelated but it might be better to keep all the log4j changes together in one patch. I can move it to a separate patch if that would be preferred.