refactor: simplify schema property filtering with class-based approach - #1
Merged
PVinaches merged 1 commit intoJul 30, 2026
Conversation
Replace functional implementation with SchemaPropertyFilter class for better code organization and maintainability. Changes: - Rename get-filtered-properties.ts → SchemaPropertyFilter.ts - Convert from functional to class-based static methods - Add type guards (hasNestedProperties, hasArrayItemProperties, isMatchablePrimitive) - Extract helper methods for better separation of concerns: - matchesKeyOrTitle() - centralized key/title matching - matchesModelValue() - value-based matching logic - getNestedModelSlice() - type-safe model extraction for objects - getArrayModelSlice() - type-safe model extraction for arrays - filterObjectProperty() - dedicated object filtering - filterArrayProperty() - dedicated array filtering - matchesPrimitiveProperty() - primitive property matching - Improve documentation with JSDoc comments - Enhance type safety throughout the implementation - Maintain all existing functionality and test coverage The new structure makes the code more maintainable by breaking down complex logic into focused, well-documented methods while preserving the original filtering behavior.
PVinaches
approved these changes
Jul 30, 2026
PVinaches
merged commit Jul 30, 2026
b40e2f8
into
PVinaches:filter-improve-backport
0 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Replace functional implementation with SchemaPropertyFilter class for better code organization and maintainability.
Changes
The new structure makes the code more maintainable by breaking down complex logic into focused, well-documented methods while preserving the original filtering behavior.