🩹 [Patch]: Add retry on Install-PSResource
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This patch adds retry logic to the module installation process in the workflow to improve reliability of the Install-PSResource command.
- Implements a retry mechanism with up to 5 attempts and a 10-second delay between retries
- Logs installation attempts and warnings on failure, then imports the module on success
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/Action-Test.yml | Added retry mechanism to the Install-PSResource command |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/Action-Test.yml:151
- Consider using a more detailed error message in the catch block by referencing $_.Exception.Message to provide clearer diagnostic information.
Write-Warning "Installation of $name failed with error: $_"
.github/workflows/Action-Test.yml:155
- [nitpick] Consider including the current retry attempt number in the warning message to provide additional context for debugging.
Write-Warning "Retrying in $retryDelay seconds..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
.github/workflows/Action-Test.ymlfile to improve the reliability of module installation by adding retry logic.Improvements to module installation:
.github/workflows/Action-Test.yml: Added a retry mechanism for theInstall-PSResourcecommand to handle potential installation failures more gracefully. This includes retrying the installation up to 5 times with a 10-second delay between attempts and logging appropriate messages.Type of change
Checklist